-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dropping unpkg remote dependency #1646
Comments
Interesting, didn't get this error so far. I see that Stryker Dashboard uses the same url: <script src="https://www.unpkg.com/mutation-testing-elements@1.7.8/dist/mutation-test-elements.js"></script> cc @nicojs - did you experience (or Stryker users) anything like this? |
Yeah unpkg isn't the most reliable CDN out there. Might be time to switch over to a locally served one, or include it in the JS bundle. Feel free to open an issue at the dashboard GH repo |
I like the idea of using URL because you automatically get the new updates. With bundled JS into the file, this will be missed. So probably it's better to move from unpkg |
True, we would get new updates through dependabot |
Consider using https://www.jsdelivr.com/, its built for high availability. |
Closed with stryker-mutator/stryker-dashboard#215 |
* Change CDN URL for mutation-testing-elements.js Fixes #1646 * Use `composer install`, not `update` for MT annotations
Thank you guys for your help and recommendations, made the same change on generated HTML by Infection. |
Is your feature request related to a problem? Please describe.
I just started using Infection and I noted that the generated HTML log includes a call to a remote resource:
Unfortunately, this URL is not available 100% of the time and I'm getting constant timeout issues that restrict me from seeing the HTML logs.
Describe the solution you'd like
I would like to be able to work with Infection without having to depend on a remotely hosted resource that could fail at any time.
Describe alternatives you've considered
I believe that the
mutation-testing-elements
js should be included in local, otherwise host it in a more reliable place (GitHub pages?)Additional context
The text was updated successfully, but these errors were encountered: