Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory resolution inconsistency #857

Open
Bilge opened this issue Nov 26, 2019 · 3 comments
Open

Directory resolution inconsistency #857

Bilge opened this issue Nov 26, 2019 · 3 comments
Labels

Comments

@Bilge
Copy link
Contributor

Bilge commented Nov 26, 2019

Given the following JSON configuration fragment

    "source": {
        "directories": [
            "foo"
        ]
    },
    "phpUnit": {
        "configDir": "bar"
    },
  • foo is resolved relative to the current working directory.
  • bar is resolved relative to the location of the configuration file.

This is inconsistent and unexpected behaviour.

@theofidry
Copy link
Member

👍 I would expect both to be relative to the configuration file

@theofidry theofidry added the Bug label Nov 26, 2019
@Bilge
Copy link
Contributor Author

Bilge commented Nov 26, 2019

Note there are other directory specifiers in a typical configuration file to which this also applies, e.g. log file location.

maks-rafalko added a commit that referenced this issue May 11, 2023
* #857 Treat log paths as relative to config directory

* Do not make abusolute path if `php://stdout`, `php://stderr` are used

* Do not make abusolute path if `php://stdout`, `php://stderr` are used

---------

Co-authored-by: Leo Viezens <leo.viezens@web.de>
@maks-rafalko
Copy link
Member

Note there are other directory specifiers in a typical configuration file to which this also applies, e.g. log file location.

this one has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants