Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecrementInteger mutator should not decrement zero indexes for array access #1281

Merged
merged 4 commits into from
Jul 9, 2020
Merged

DecrementInteger mutator should not decrement zero indexes for array access #1281

merged 4 commits into from
Jul 9, 2020

Conversation

LoopKarma
Copy link
Contributor

maks-rafalko
maks-rafalko reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR!

Could you please look into failed Travis builds? It looks like some of the e2e tests are failing.

You can run them as ./tests/e2e_tests bin/infection

@LoopKarma LoopKarma force-pushed the pr/2020-07/decrement-mutator-fix branch 2 times, most recently from 9569ec9 to 0759a30 Compare July 8, 2020 22:03
@LoopKarma LoopKarma force-pushed the pr/2020-07/decrement-mutator-fix branch from 0759a30 to f79ea94 Compare July 8, 2020 22:09
@LoopKarma LoopKarma force-pushed the pr/2020-07/decrement-mutator-fix branch from 9034bdf to 9d53516 Compare July 8, 2020 22:17
@maks-rafalko maks-rafalko added this to the 0.17.0 milestone Jul 9, 2020
@maks-rafalko
Copy link
Member

I pushed a fix for e2e tests, now CI is happy.

Thank you for this contribution, @LoopKarma!

@maks-rafalko maks-rafalko merged commit 5682c2e into infection:master Jul 9, 2020
@LoopKarma LoopKarma deleted the pr/2020-07/decrement-mutator-fix branch July 9, 2020 21:10
@LoopKarma
Copy link
Contributor Author

@maks-rafalko happy to help! Strange but I got errors in another e2e tests than Travis. How you came up that specifically this test should be improved?

@maks-rafalko
Copy link
Member

How you came up that specifically this test should be improved?

I ran tests/e2e_tests bin/infection and analyzed the output. There was something about difference between expected and actual output

@LoopKarma
Copy link
Contributor Author

@maks-rafalko interesting, I ran the same command but got nothing for local php but got errors in other tests under docker setup. For sure I missed something here, since I'm pretty green here )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Decrement mutator makes array indexes negative
2 participants
@LoopKarma @maks-rafalko