Bump PHP-Parser #1354
Merged
Bump PHP-Parser #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did I get it right that we can't merge it? (because of that issue) |
|
No, we can't. Phar build is broken. |
|
I think I'll leave thing handing just on the off chance @theofidry can know what's up here. |
sanmai
requested review from
maks-rafalko
and removed request for
maks-rafalko
|
@maks-rafalko Now I can build it just fine locally. |
sanmai
commented
Oct 21, 2020
| 'T_NAME_RELATIVE', | ||
| 'T_MATCH', | ||
| 'T_NULLSAFE_OBJECT_OPERATOR', | ||
| 'T_ATTRIBUTE', |
There was a problem hiding this comment.
Taken from here:
PHP-Scooper does not know that it must whitelist these otherwise.
There was a problem hiding this comment.
Could this be added to https://github.com/humbug/php-scoper/blob/master/src/Reflector.php#L64?
There was a problem hiding this comment.
Absolutely. I thought there must be something like this, but couldn't find this straight away.
|
This should be not very hard to backport. |
sanmai
added a commit
to sanmai/infection
that referenced
this pull request
Oct 21, 2020
* Whitelist PHP 8.0 constants in scoper.inc.php
sanmai
added a commit
to sanmai/infection
that referenced
this pull request
Oct 21, 2020
* Whitelist PHP 8.0 constants in scoper.inc.php
maks-rafalko
pushed a commit
that referenced
this pull request
Oct 21, 2020
* Bump PHP-Parser (#1354) * Whitelist PHP 8.0 constants in scoper.inc.php * Fix PHPStan warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
PHP-Parser had an issue, but apparently it's gone in newer versions.It is still there: