Add more tests for DecrementInteger, IncrementInteger and OneZeroInteger mutators #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidz
commented
Oct 19, 2020
| @@ -62,15 +62,6 @@ public function mutationsProvider(): iterable | |||
| , | |||
| ]; | |||
|
|
|||
| yield 'It does not decrement the number one' => [ | |||
There was a problem hiding this comment.
maks-rafalko
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to add more tests for DecrementInteger, IncrementInteger and OneZeroInteger mutators as I have a strong feeling that I may break current behavior in #1347.
The idea is to cover all possible scenarios in current master and before I'll start to do changes in #1347 in order to show how exactly these mutators currently do their job to avoid possible questions in those PR.