Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GitHub annotation work when Infection is run in subdirectory #1576

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Make GitHub annotation work when Infection is run in subdirectory #1576

merged 1 commit into from
Sep 14, 2021

Conversation

kubawerlos
Copy link
Contributor

When Infection is run in Git's repository root (with ./backend/vendor/bin/infection) then logged warnings are fine:

::warning file=backend/src/Foo.php,line=42::Escaped Mutant for Mutator (...)

However, when Infection is run in subdirectory (backend, with command ./vendor/bin/infection) then logged warnings are like this:

::warning file=src/Foo.php,line=42::Escaped Mutant for Mutator (...)

which makes Github annotation not working.

This change fixes that problem.

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kubawerlos

@maks-rafalko maks-rafalko merged commit b4f7249 into infection:master Sep 14, 2021
@kubawerlos kubawerlos deleted the allow_to_run_GitHubAnnotationsLogger_from_subdirectory branch September 14, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants