Integrate sidz/phpstan-rules to avoid magic numbers in our code base
#1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
unrelated, but thanks for the service |
sidz
reviewed
May 15, 2023
maks-rafalko
changed the title
sidz/phpstan-rules to avoid magic numbers in our code basesidz/phpstan-rules to avoid magic numbers in our code base
|
Thank you, @sidz |
maks-rafalko
added a commit
to maks-rafalko/phpstan
that referenced
this pull request
May 23, 2023
I propose to add a 3rd-party package to documentation about detecting Magic Numbers in the code: https://github.com/sidz/phpstan-rules This is a replacement for https://github.com/povils/phpmnd (standalone CLI tool) We have already integrated in several projects at our company and I personally add it to @infection (infection/infection#1861) Would love to share this great package with more developers.
ondrejmirtes
pushed a commit
to phpstan/phpstan
that referenced
this pull request
May 30, 2023
I propose to add a 3rd-party package to documentation about detecting Magic Numbers in the code: https://github.com/sidz/phpstan-rules This is a replacement for https://github.com/povils/phpmnd (standalone CLI tool) We have already integrated in several projects at our company and I personally add it to @infection (infection/infection#1861) Would love to share this great package with more developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PHPStan plugin from our @sidz
No magic numbers!