Simplify the EventDispatcher #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of its public functions were not being used within the code base (anymore). Removed the unused functions, the now useless interface, and updated tests to show this new behaviour.
And update tests to mock the inferface, and mark the normall class as final.
sidz
approved these changes
May 12, 2018
| { | ||
| if (!$this->hasListeners($eventName)) { | ||
| if (!isset($this->listeners[$eventName])) { |
There was a problem hiding this comment.
can be simplified as well:
return $this->listeners[$eventName] ?? [];
| */ | ||
| public function getListeners($eventName) | ||
| private function getListeners($eventName) |
There was a problem hiding this comment.
seems like we can add string type hinting here
maks-rafalko
approved these changes
May 12, 2018
|
Thank you @BackEndTea |
|
Thank you @borNfreee @sidz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Most of its public functions were not being used within the code base(anymore).
Removed the unused functions, the now useless interface,and updated tests to show this behaviour.