Update TestFrameworkFinder to always look for a .bat first. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
No need to add more tests, this PR supposed to fix an existing test. |
maks-rafalko
approved these changes
Oct 15, 2018
BackEndTea
pushed a commit
to BackEndTea/infection
that referenced
this pull request
Oct 22, 2018
…n#506) * Update TestFrameworkFinder to always look for a .bat first. Fixes infection#503 * Phpunit_Bat_Wrapper: add cwd to path just for this test * Phpunit_Bat_Wrapper: it does not matter if Infection succeeds, only it must find phpunit.bat
sanmai
added a commit
to sanmai/infection
that referenced
this pull request
Oct 27, 2018
…n#506) * Update TestFrameworkFinder to always look for a .bat first. Fixes infection#503 * Phpunit_Bat_Wrapper: add cwd to path just for this test * Phpunit_Bat_Wrapper: it does not matter if Infection succeeds, only it must find phpunit.bat
3 tasks
maks-rafalko
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Restrict installation with broken versions of symfony/console Also ignore bogus PHPStan warnings. * Update TestFrameworkFinder to always look for a .bat first. (#506) * Update TestFrameworkFinder to always look for a .bat first. Fixes #503 * Phpunit_Bat_Wrapper: add cwd to path just for this test * Phpunit_Bat_Wrapper: it does not matter if Infection succeeds, only it must find phpunit.bat
raphaelstolt
pushed a commit
to raphaelstolt/infection
that referenced
this pull request
Nov 2, 2018
…n#506) * Update TestFrameworkFinder to always look for a .bat first. Fixes infection#503 * Phpunit_Bat_Wrapper: add cwd to path just for this test * Phpunit_Bat_Wrapper: it does not matter if Infection succeeds, only it must find phpunit.bat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503