Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use plural for method name as it returns a generator #546

Merged
merged 1 commit into from Nov 5, 2018
Merged

Fix: Use plural for method name as it returns a generator #546

merged 1 commit into from Nov 5, 2018

Conversation

localheinz
Copy link
Member

This PR

  • renames a method returning a generator

💁‍♂️ I think it makes sense as the generator potentially yields more than one index.

tests-checker[bot]
tests-checker bot suggested changes Nov 4, 2018
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Infection. We noticed you didn't add any tests. Could you please add them to make sure everything works as expected?

@maks-rafalko maks-rafalko merged commit e85f05f into infection:master Nov 5, 2018
@maks-rafalko
Copy link
Member

Thank you @localheinz

@localheinz localheinz deleted the fix/plural branch November 5, 2018 05:56
@localheinz
Copy link
Member Author

Thank you, @borNfreee and @sanmai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

@sanmai sanmai sanmai approved these changes

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@localheinz @maks-rafalko @sanmai