Symfony 6 support #12
Conversation
sidz
commented
Nov 6, 2021
sidz
commented
- Add Symfony 6 support
- Mark 4.4 as minimum supported version
- Test adapter against supported versions of symfony packages
sidz
force-pushed
the
support-symfony-6
branch
2 times, most recently
from
cdf0d32
to
e5e2804
Compare
| PHP_CS_FIXER_ARGS=--diff --diff-format=udiff --verbose | ||
| export PHP_CS_FIXER_IGNORE_ENV=1 | ||
| PHP_CS_FIXER=./.tools/php-cs-fixer | ||
| PHP_CS_FIXER_URL="https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v3.2.1/php-cs-fixer.phar" |
There was a problem hiding this comment.
php-cs-fixer is not compatible with symfony 6 yet.
waiting PHP-CS-Fixer/PHP-CS-Fixer#6095 to be merged and new release
sidz
force-pushed
the
support-symfony-6
branch
2 times, most recently
from
3b1ddc0
to
2c5e282
Compare
| ; | ||
|
|
||
| return Config::create() | ||
| return (new Config()) |
There was a problem hiding this comment.
config has been copied from infection/infection repo
| /** | ||
| * @internal | ||
| */ | ||
| final class PhpSpecExtraOptions |
There was a problem hiding this comment.
looks like dead code. Am I missed smth?
…supported versions of symfony packages
sidz
force-pushed
the
support-symfony-6
branch
from
2c5e282
to
2b47b6e
Compare
| php-version: ['7.4', '8.0', '8.1'] | ||
| coverage-driver: [pcov] | ||
| symfony-require: ['^4', '^5', '^6'] | ||
| exclude: | ||
| - symfony-require: "^6" |
There was a problem hiding this comment.
symfony 6 requires "php": ">=8.0.2"
| @@ -13,14 +13,19 @@ on: | |||
| jobs: | |||
| tests: | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| SYMFONY_REQUIRE: ${{ matrix.symfony-require }} | |||
There was a problem hiding this comment.
is it somehow used by composer to require symfony of particular version during composer update? As I don't see where we explicitly require the needed version (^5, ^6 ...)
There was a problem hiding this comment.
symfony flex does it for us.
https://github.com/symfony/flex/blob/7f45cf796f591ad8c1cc56ccc8edc32d78172258/src/Flex.php#L125
sidz
force-pushed
the
support-symfony-6
branch
from
a133116
to
efa8ace
Compare
|
merged. Thanks @maks-rafalko |
