Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for --coverage option #41

Closed
maks-rafalko opened this issue May 17, 2018 · 0 comments · Fixed by #43
Closed

Update documentation for --coverage option #41

maks-rafalko opened this issue May 17, 2018 · 0 comments · Fixed by #43

Comments

@maks-rafalko
Copy link
Member

maks-rafalko commented May 17, 2018 •
edited
Loading

Make it more clear for users that Infection requires BOTH xml and junit reports.

Visually underline it.

From reporter:

I didn't really read it as "BOTH ... AND ...", rather like "supports ... AND ..."
because it's totally unnatural to require two reports that represent the same
nstapelbroek added a commit to nstapelbroek/site that referenced this issue Jun 8, 2018
@nstapelbroek
Use the word "both" in the PHPUnit --coverage docs
1e1c718 
By inserting the word "both" it should be more clear that both report types are required for infection to work with the flag. Closes infection#41
@nstapelbroek nstapelbroek mentioned this issue Jun 8, 2018
Merged
maks-rafalko pushed a commit that referenced this issue Jun 8, 2018
@nstapelbroek @maks-rafalko
Use the word "both" in the PHPUnit --coverage docs (#43)
3b73c2b 
By inserting the word "both" it should be more clear that both report types are required for infection to work with the flag. Closes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the word "both" in the PHPUnit --coverage docs nstapelbroek/site
1 participant
@maks-rafalko