Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeon's Mobs compatibility for Wraith Fire #325

Open
wants to merge 1 commit into
base: 1.16
Choose a base branch
from

Conversation

Jellybubble
Copy link
Contributor

Added DM fire compat

@Jellybubble
Copy link
Contributor Author

Jellybubble commented Feb 13, 2022

Finally got around to testing this out successfully, and it failed.
The overlay did not update with the wraith fire texture, which I believe is due to the method by how wraith fire is spawned.
In order to spawn the wraith fire, a wraith fire charge needs to come into contact with a block.
This means that there may need to be a special case for the wraith fire, however, I do not know how to code this feature myself.

@LudoCrypt
Copy link
Contributor

How the wraith fire is spawned has nothing to do with the overlay texture; Though, I was searching through their block code, and it looks like its an issue on their end. See, since we're mixing into the AbstractFireBlock's 'onEntityCollision' method, that makes all blocks extending that class run out code. However, in WraithFireBlock's case, its overriding said method without doing the super call, hence why no effect is present. You can see so here
https://github.com/Thelnfamous1/Dungeons-Mobs/blob/1.16.4/src/main/java/com/infamous/dungeons_mobs/blocks/WraithFireBlock.java#L106
Though, it is under different mappings.
Your code looks fine to me!

@SwanX1
Copy link
Member

SwanX1 commented Feb 14, 2022

I've already tried to implement this, however to no avail due to the issue @LudoCrypt has mentioned. This isn't a fault at our end, it's just not feasible to implement this.
See: SwanX1/infexp@e46e123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants