Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Updates #1

Merged
merged 20 commits into from
Apr 29, 2024
Merged

Documentation Updates #1

merged 20 commits into from
Apr 29, 2024

Conversation

karlnaden
Copy link
Collaborator

@karlnaden karlnaden commented Apr 24, 2024

Summary

Update documentation and test descriptions based on feedback from ONC, including

  • splitting out suite descriptions into separate markdown files that can be linked to from test descriptions and other documentation
  • add additional description to user input validation tests
  • clarify the meaning of the server "status check" tests -> now claim response decision validation, and move them into the submit group rather than their own group. Also made them skip and optional until actually implemented.
  • Separate out the stub notification test.

Testing Guidance

  • note that some links point explicitly to a file that doesn't yet exist in the main brach, so you will need to add the branch name to the url (after /tree/ -> /tree/suite_description_breakouts/) for the link to work from descriptions in the running test kit.

@karlnaden
Copy link
Collaborator Author

karlnaden commented Apr 24, 2024

One remaining question. Scott had a suggestion to update the description of the $submit and $inquiry operations. My note indicates "expand description of operations -> both described in the IG as "submit a claim for..."". I think our descriptions seem pretty good, at least in the client tests:

  • submit: submits a claim using the $submit operation
  • inquiry: inquires about a pended claim using the $inquire operation

so I took the approach of updating the server to follow those names. Does this sound right @arscan - did you think there was something different that Scott wanted here?

karlnaden and others added 3 commits April 25, 2024 14:18
…ecision/pas_claim_response_decision_test.rb

Co-authored-by: Vanessa Fotso <46642178+vanessuniq@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Vanessa Fotso <46642178+vanessuniq@users.noreply.github.com>
### Postman-based Demo

If you do not have a PAS client but would like to try the tests out, you can use
[this postman collection](https://raw.githubusercontent.com/inferno-framework/davinci-pas-test-kit/blob/main/config/PAS%20Test%20Kit%20Client%20Test%20Demo.postman_collection.json)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This absolute link doesn't work. The link in the suite description in the running version on inferno.healthit.gov is currently broken as well. I think you need to remove the blob segment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arscan
Copy link
Contributor

arscan commented Apr 26, 2024

so I took the approach of updating the server to follow those names. Does this sound right @arscan - did you think there was something different that Scott wanted here?

I think this is ok. The issue is that we tend to want to use very precise language from the spec so everyone knows what we are formally testing. The formal language here is... well... not great... because "submit" is used to mean 2 different things in the 2 operations. So either we update this to use not-great language that clearly maps to the operation names/titles, or we change the language on our side to 'make more sense'. Maybe we can open a ticket for them to not use 'submit' in the $inquire operation definition? Or something like that?

@karlnaden
Copy link
Collaborator Author

so I took the approach of updating the server to follow those names. Does this sound right @arscan - did you think there was something different that Scott wanted here?

I think this is ok. The issue is that we tend to want to use very precise language from the spec so everyone knows what we are formally testing. The formal language here is... well... not great... because "submit" is used to mean 2 different things in the 2 operations. So either we update this to use not-great language that clearly maps to the operation names/titles, or we change the language on our side to 'make more sense'. Maybe we can open a ticket for them to not use 'submit' in the $inquire operation definition? Or something like that?

Good idea. Submitted FHIR-45391. Also created FHIR-45393 around the inquire vs inquiry issue, which has been bothering me.

@arscan
Copy link
Contributor

arscan commented Apr 29, 2024

Good idea. Submitted FHIR-45391. Also created FHIR-45393 around the inquire vs inquiry issue, which has been bothering me.

I think having it be more active in its phrasing with the primary verb being up-front would be clearest.... "Inquire about the status of a submitted claim" or something. But coming up with concise and clear language here is very hard (I sympathize with IG devs!)

@karlnaden
Copy link
Collaborator Author

But coming up with concise and clear language here is very hard (I sympathize with IG devs!)

I do too!

@karlnaden karlnaden merged commit b0577ad into main Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants