-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Updates #1
Conversation
One remaining question. Scott had a suggestion to update the description of the $submit and $inquiry operations. My note indicates "expand description of operations -> both described in the IG as "submit a claim for..."". I think our descriptions seem pretty good, at least in the client tests:
so I took the approach of updating the server to follow those names. Does this sound right @arscan - did you think there was something different that Scott wanted here? |
...as_test_kit/custom_groups/v2.0.1/claim_response_decision/pas_claim_response_decision_test.rb
Outdated
Show resolved
Hide resolved
…ecision/pas_claim_response_decision_test.rb Co-authored-by: Vanessa Fotso <46642178+vanessuniq@users.noreply.github.com>
Co-authored-by: Vanessa Fotso <46642178+vanessuniq@users.noreply.github.com>
### Postman-based Demo | ||
|
||
If you do not have a PAS client but would like to try the tests out, you can use | ||
[this postman collection](https://raw.githubusercontent.com/inferno-framework/davinci-pas-test-kit/blob/main/config/PAS%20Test%20Kit%20Client%20Test%20Demo.postman_collection.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This absolute link doesn't work. The link in the suite description in the running version on inferno.healthit.gov is currently broken as well. I think you need to remove the blob
segment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/inferno-framework/davinci-pas-test-kit/blob/main/config/PAS%20Test%20Kit%20Client%20Test%20Demo.postman_collection.json is the link when I navigate to the file, so using that.
I think this is ok. The issue is that we tend to want to use very precise language from the spec so everyone knows what we are formally testing. The formal language here is... well... not great... because "submit" is used to mean 2 different things in the 2 operations. So either we update this to use not-great language that clearly maps to the operation names/titles, or we change the language on our side to 'make more sense'. Maybe we can open a ticket for them to not use 'submit' in the $inquire operation definition? Or something like that? |
Good idea. Submitted FHIR-45391. Also created FHIR-45393 around the inquire vs inquiry issue, which has been bothering me. |
I think having it be more active in its phrasing with the primary verb being up-front would be clearest.... "Inquire about the status of a submitted claim" or something. But coming up with concise and clear language here is very hard (I sympathize with IG devs!) |
I do too! |
Summary
Update documentation and test descriptions based on feedback from ONC, including
Testing Guidance