Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2182: Upgrade to TypeScript 5 #418

Merged
merged 4 commits into from Jan 5, 2024
Merged

FI-2182: Upgrade to TypeScript 5 #418

merged 4 commits into from Jan 5, 2024

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Upgrades TypeScript from version 4 to version 5. Override for react-scripts necessary due to open issue facebook/create-react-app#13080.

Testing Guidance

Should just run as usual + pass all lint/test checks.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec13589) 77.02% compared to head (c719d22) 77.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files         218      218           
  Lines       10914    10914           
  Branches     1026     1026           
=======================================
  Hits         8407     8407           
  Misses       1928     1928           
  Partials      579      579           
Flag Coverage Δ
backend 93.89% <ø> (ø)
frontend 69.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine for me!

@AlyssaWang AlyssaWang merged commit bea4123 into main Jan 5, 2024
10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2182-typescript branch January 5, 2024 22:47
@rpassas rpassas mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants