Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2392-header-jog #422

Merged
merged 1 commit into from
Dec 21, 2023
Merged

FI-2392-header-jog #422

merged 1 commit into from
Dec 21, 2023

Conversation

AlyssaWang
Copy link
Collaborator

Removes margin before React loading to fix slight header jog

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (983b94c) 77.03% compared to head (b50a804) 77.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         218      218           
  Lines       10913    10913           
  Branches     1026     1026           
=======================================
  Hits         8407     8407           
  Misses       1927     1927           
  Partials      579      579           
Flag Coverage Δ
backend 93.89% <ø> (ø)
frontend 69.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixed the problem in both mobile and desktop sized windows.

@AlyssaWang AlyssaWang merged commit 0e4c42a into main Dec 21, 2023
10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2392-header-jog branch December 21, 2023 18:47
@rpassas rpassas mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants