Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2396-redirect-session #426

Merged
merged 1 commit into from
Jan 5, 2024
Merged

FI-2396-redirect-session #426

merged 1 commit into from
Jan 5, 2024

Conversation

AlyssaWang
Copy link
Collaborator

Summary

Adds a check for the root of the URL for the new session redirect event; if there is no basePath defined, the root will default to the existing location origin. This will break if the origin and the intended base path are different.

Testing Guidance

TBD

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (95adb9b) 77.03% compared to head (08ee961) 77.02%.

Files Patch % Lines
...c/components/SuiteOptionsPage/SuiteOptionsPage.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   77.03%   77.02%   -0.01%     
==========================================
  Files         218      218              
  Lines       10913    10914       +1     
  Branches     1026     1026              
==========================================
  Hits         8407     8407              
- Misses       1927     1928       +1     
  Partials      579      579              
Flag Coverage Δ
backend 93.89% <ø> (ø)
frontend 69.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to recreate the error using g10 (as it has an options page) within core, deleting the BASE_PATH=inferno in .env.development. Then switched to this branch, and confirmed that the error no longer happened. Also confirmed that requests are still made in between the steps, so that we can intercept them properly and show a separate 'landing page' for test kits instead of them being at a suite-level.

However, there is a wierd little flicker... like the interface fades to grey, then will redirect, i guess from this workaround, whatever it is doing.

Suggest we merge this in so that it is no longer completely broken, and if it is annoying (particularly on inferno.healthit.gov) consider looking how to make it so that this 'workaround' is not needed?

@AlyssaWang
Copy link
Collaborator Author

Yep the flicker is annoying, have been trying to find a workaround for the workaround but since there's a double reload I think it stays unless we come up with another solution here for the requests/routing.

@AlyssaWang AlyssaWang merged commit ec13589 into main Jan 5, 2024
9 of 10 checks passed
@AlyssaWang AlyssaWang deleted the FI-2396-redirect-session branch January 5, 2024 20:24
@rpassas rpassas mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants