New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2405: Create skeleton loader for main app #440
Conversation
… FI-2405-skeleton-loader-main
… FI-2405-skeleton-loader-main
… FI-2405-skeleton-loader-main
… FI-2405-skeleton-loader-main
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 77.09% 77.32% +0.22%
==========================================
Files 220 225 +5
Lines 10951 11200 +249
Branches 1030 1052 +22
==========================================
+ Hits 8443 8660 +217
- Misses 1929 1939 +10
- Partials 579 601 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge improvement! I tried it out with our demo suites, and also g10 after running the full suite of single patient api tests, which causes the interface load time to be a bit long right now. A todo for us is to optimize some of our db calls to improve load time, but this is a nice short term measure for that, plus being noticeably better in the regular case.
My only concern here is that it would add enough complexity and/or maintenance effort when we update the look and feel to make it simply not worthwhile to put in. But in looking through the code, it looks like there are very few spots in the 'real' interface that link over to this skeleton (so, low complexity), and the skeleton API seems really simple to update (so, low enough maintenance cost for if/when we update the UI). So I definitely think its worthwhile.
I'm not so concerned about skeletons on the landing/suites part of the UI, as that has a decent likelyhood of being refactored down the road as we consider backporting jekyll updates we made to inferno.healthit.gov into the test kit template.
I did see a bit of a flicker for suites with options due to some kind of reloading going on, which might be a little more annoying now that this page isn't just a grey blob, but I think we are aware of that issue. |
Summary
Adds skeleton loading components to the test session portion of Inferno. Follow up tickets will implement skeletons for the landing page and suite options page.
Testing Guidance
Skeletons should appear while portions of the application are loading. Please let me know if they aren't doing so!