Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2567: Fix client instance variables #464

Merged
merged 3 commits into from Mar 8, 2024

Conversation

Jammjammjamm
Copy link
Collaborator

Summary

FHIR/HTTP clients were incorrectly using call instead of send when delegating methods to the runnable in which they are defined.

Testing Guidance

The unit tests are adequate to demonstrate this failure. Check out 958ef0d28b431d2d01d7cb651d503182b2e8f37b to see the tests fail.

@Jammjammjamm Jammjammjamm self-assigned this Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.69%. Comparing base (e7663b7) to head (985a7f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   77.68%   77.69%   +0.01%     
==========================================
  Files         233      233              
  Lines       11591    11591              
  Branches     1087     1087              
==========================================
+ Hits         9004     9006       +2     
+ Misses       1967     1965       -2     
  Partials      620      620              
Flag Coverage Δ
backend 93.96% <100.00%> (+0.05%) ⬆️
frontend 70.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm merged commit 1c9c0b0 into main Mar 8, 2024
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2567-fix-client-instance-variables branch March 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants