Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have gemspec include dotfiles from lib/inferno/apps/cli/templates/ #470

Merged
merged 5 commits into from Mar 29, 2024

Conversation

Shaumik-Ashraf
Copy link
Contributor

Summary

The line Dir[lib/inferno/apps/cli/templates/**/*] excludes all dotfiles from shipping to RubyGems, so it was missing .keep files and .env files. I'm now using **/{*,.*} to capture all dotfiles. Using Dir.glob('**/*', File::FNM_DOTMATCH) includes . and .. files and I'm not sure how RubyGems will react to that.

Testing Guidance

  1. npm run build && gem build inferno_core.gemspec
  2. Move and extract the new gem
  3. Run bin/inferno new foo

The golden test will be when someone else pulls it from RubyGems and it works. In the meantime I'll keep tabs on it.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (b8a59d5) to head (6042f9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files         234      234           
  Lines       11622    11622           
  Branches     1095     1095           
=======================================
  Hits         9039     9039           
  Misses       1963     1963           
  Partials      620      620           
Flag Coverage Δ
backend 94.07% <ø> (ø)
frontend 70.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shaumik-Ashraf Shaumik-Ashraf merged commit fa0ba93 into main Mar 29, 2024
10 checks passed
@Shaumik-Ashraf Shaumik-Ashraf deleted the fi-2594-inferno-new-missing-dotfiles branch March 29, 2024 14:45
@rpassas rpassas mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants