have gemspec include dotfiles from lib/inferno/apps/cli/templates/ #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The line
Dir[lib/inferno/apps/cli/templates/**/*]
excludes all dotfiles from shipping to RubyGems, so it was missing .keep files and .env files. I'm now using**/{*,.*}
to capture all dotfiles. UsingDir.glob('**/*', File::FNM_DOTMATCH)
includes.
and..
files and I'm not sure how RubyGems will react to that.Testing Guidance
npm run build && gem build inferno_core.gemspec
bin/inferno new foo
The golden test will be when someone else pulls it from RubyGems and it works. In the meantime I'll keep tabs on it.