Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2664: Prevent validator sessions from being created in test environment #477

Merged
merged 1 commit into from Apr 8, 2024

Conversation

Jammjammjamm
Copy link
Collaborator

@Jammjammjamm Jammjammjamm commented Apr 8, 2024

This prevents validator sessions from being created in the test environment. The validator is not expected to be running during unit tests, so it will not be reachable. By default, the validator is going to be using a docker hostname, which causes a DNS error when trying to create a session, preventing unit tests from running in test kits which use the new validator. This happens when Inferno boots (i.e. prior to unit test execution), so this can't be handled by stubbing the requests.

@Jammjammjamm Jammjammjamm requested a review from arscan April 8, 2024 15:14
@Jammjammjamm Jammjammjamm self-assigned this Apr 8, 2024
@Jammjammjamm Jammjammjamm force-pushed the fi-2664-prevent-validator-sessions-in-test branch from 077dcea to 47cfeef Compare April 8, 2024 15:15
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (3047f95) to head (47cfeef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   77.77%   77.74%   -0.04%     
==========================================
  Files         234      234              
  Lines       11622    11623       +1     
  Branches     1095     1096       +1     
==========================================
- Hits         9039     9036       -3     
- Misses       1963     1967       +4     
  Partials      620      620              
Flag Coverage Δ
backend 93.96% <100.00%> (-0.12%) ⬇️
frontend 70.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm Jammjammjamm merged commit 077b78b into main Apr 8, 2024
10 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2664-prevent-validator-sessions-in-test branch April 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants