Change deprecated call, cleanup and and typing

infernojs · Dec 28, 2022 · 008c04a · 008c04a
1 parent 4504158
commit 008c04a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/inferno-router/src/StaticRouter.ts b/packages/inferno-router/src/StaticRouter.ts
@@ -103,7 +103,7 @@ function addBasename(basename, location) {
   return combineFrom(location, { pathname: addLeadingSlash(basename) + location.pathname });
 }
 
-function stripBasename(basename, location) {
+function stripBasename(basename: string, location) {
   if (!basename) {
     return location;
   }
@@ -114,7 +114,7 @@ function stripBasename(basename, location) {
     return location;
   }
 
-  return combineFrom(location, { pathname: location.pathname.substr(base.length) });
+  return combineFrom(location, { pathname: location.pathname.substring(base.length) });
 }
 
 function createLocation(location) {

diff --git a/packages/inferno-router/src/resolveLoaders.ts b/packages/inferno-router/src/resolveLoaders.ts
@@ -110,9 +110,8 @@ function createClientSideRequest(
   signal: AbortSignal,
   // submission?: Submission
 ): Request {
-  let url = createClientSideURL(location);
-  url.hash = '';
-  let init: RequestInit = { signal };
+  const url = createClientSideURL(location);
+  const init: RequestInit = { signal };
 
   // TODO: react-router supports submitting forms with loaders, but this needs more investigation
   // related code is commented out in this file