Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please improve the typescript declare files ! #1295

Closed
pedrogao opened this issue Mar 3, 2018 · 5 comments
Closed

Please improve the typescript declare files ! #1295

pedrogao opened this issue Mar 3, 2018 · 5 comments

Comments

@pedrogao
Copy link

pedrogao commented Mar 3, 2018

The .d.ts files has some mistakes which always made me confuse,would you improve them?

@Havunen
Copy link
Member

Havunen commented Mar 3, 2018

@pedrogao It would help if you could tell where the issue is. Its open source project so if you find something to improve you can also contribute! There is btw pull request for more types, maybe you could code review that #1287. And possibly test it and give feed back for the PR author.

@Havunen
Copy link
Member

Havunen commented Mar 3, 2018

Generally we want to improve this area there are couple of issues about this already:
#686

@pedrogao
Copy link
Author

pedrogao commented Mar 3, 2018

okay ! Thank you very muck!

@pedrogao
Copy link
Author

pedrogao commented Mar 3, 2018

I just a newcomer of github and my English is poor ! So I just can write my suggestions here.

  1. change the props of the router. I have checked the declare files of react-router , and I think the Props of Inferno-router should be like this above.
export interface IRouteProps {
    computedMatch?: any;
    path: any;
    exact?: any;
    strict?: any;
    sensitive?: any;
    component?: any;
    render?: any;
    location?: any;
    children?: Array<Component<any, any>>;
  }
  1. this is my declare files of inferno. .d.ts

This is all.

as-com added a commit to as-com/inferno that referenced this issue Mar 11, 2018
Havunen pushed a commit that referenced this issue Mar 17, 2018
* Add enhanced typings

* Cleanup

* Import JSX, whoops

* Refactor Events definition; add support for linkEvent

* Remove fixed TODO

* Lots of cleanup, also address #1295

* Clean up WrapperComponent

#1287 (comment)

* Remove global.d.ts
@Havunen
Copy link
Member

Havunen commented Mar 17, 2018

V5 is released. This is fixed there

@Havunen Havunen closed this as completed Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants