Inconsistency between how inferno and inferno-server handles components returning arrays

[jhsware]

If an inferno component returns a literal array the DOM-library will render it using "mountArrayChildren", but inferno-server will throw the error "renderToString() received an object that's not a valid VNode".

Is this a bug in inferno-server or inferno?

i.e.

class MyComp extends Component {
  render() {
    return [<p>foo</p>, <p>bar</p>]
  }
}

Would render in the browser, but not on the server. Swapping array to a fragment (<></>) solves this issue.

[Havunen]

This seems like bug. Thanks for reporting it.

[jhsware]

@Havunen what is the intended behaviour? Should I see if I can suggest a fix?

[Havunen]

@jhsware Sure, basically arrays should be handled same way as fragments. See non-server side code:

https://github.com/infernojs/inferno/blob/master/packages/inferno/src/core/implementation.ts#L400-L402

I think server side could just jump into rendering children logic flow? Note that test cases needs to be added for all these 3 methods:

https://github.com/infernojs/inferno/blob/master/packages/inferno-server/src/index.ts#L9-L14

[jhsware]

@Havunen okay great, yeah I'll start by adding tests. Will see if I can figure it out Tomorrow.

[Havunen]

7.4.0 published