Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array and fragment during SSR #1503

Merged
merged 7 commits into from
Jan 28, 2020
Merged

Conversation

jhsware
Copy link
Contributor

@jhsware jhsware commented Jan 28, 2020

Added tests and implementation. Used existing code path for rendering fragments where available.

This PR closes #1501

I noticed that the tests for the three rendering methods were in separate files. This allowed them to have different feature support (fragment was missing in two). I have opened a ticket #1502

@Havunen
Copy link
Member

Havunen commented Jan 28, 2020

LGTM :)

@Havunen
Copy link
Member

Havunen commented Jan 28, 2020

Thanks for the pull request! I will merge and publish the changes when I get home.

@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2020

Coverage Status

Coverage increased (+0.05%) to 95.112% when pulling 23979bb on jhsware:master into 888b0c7 on infernojs:master.

@jhsware
Copy link
Contributor Author

jhsware commented Jan 28, 2020

I updated the PR with a fix for the tslint-error.

@Havunen Havunen merged commit 9396ade into infernojs:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between how inferno and inferno-server handles components returning arrays
3 participants