Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0.0 breaks compilation in TS projects that have React class-based components #1599

Closed
AntonOfTheWoods opened this issue Jun 19, 2022 · 3 comments
Labels

Comments

@AntonOfTheWoods
Copy link

Issue Template

Observed Behaviour

Inferno using TS is no longer compiling in projects that have React class-based components. With 7.4.11 this works with no issues.

Expected Current Behaviour

Inferno should continue to compile in projects that have React class-based components.

8.0.0

See an extremely basic example here https://github.com/AntonOfTheWoods/inferno-react-broken

The example has 3 commits:

  • initial create-react-app
  • addition of inferno and inferno-create-element version 7.4.11 with code that compiles and runs fine
  • upgrade of these two packages to 8.0.0 and no other changes and no longer compiles or runs.
@Havunen Havunen added the bug label Jun 19, 2022
@Havunen
Copy link
Member

Havunen commented Jun 19, 2022

Thanks for reporting this issue and creating simple steps to reproduce. It seems this issue was caused by type refactoring for v8. 696006c

Havunen pushed a commit that referenced this issue Jun 19, 2022
…plementation type to allow mixing usages with React application. Fixes Github #1599
@Havunen
Copy link
Member

Havunen commented Jun 19, 2022

@Havunen Havunen closed this as completed Jun 19, 2022
@AntonOfTheWoods
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants