Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize renderFunctionalComponent better #1514

Merged
merged 1 commit into from Jun 2, 2020
Merged

Optimize renderFunctionalComponent better #1514

merged 1 commit into from Jun 2, 2020

Conversation

trueadm
Copy link
Member

@trueadm trueadm commented Jun 2, 2020

I thought I'd take a stab at optimizing some code in Inferno. :)

@trueadm trueadm requested a review from Havunen June 2, 2020 13:42
@coveralls
Copy link
Collaborator

coveralls commented Jun 2, 2020 •
edited

Coverage Status

Coverage remained the same at 95.122% when pulling 1a7968f on reuseRenderFuncComp into 549bae9 on master.

Havunen
Havunen approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@Havunen Havunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@trueadm trueadm merged commit 1af165f into master Jun 2, 2020
@trueadm trueadm deleted the reuseRenderFuncComp branch June 2, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Havunen Havunen Havunen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trueadm @coveralls @Havunen