Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature support for async prefetch in inferno-router #1621

Merged
merged 72 commits into from May 13, 2023
Merged

Feature support for async prefetch in inferno-router #1621

merged 72 commits into from May 13, 2023

Commits on Apr 25, 2023

  1. initial code

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    3b8dc01 View commit details
    Browse the repository at this point in the history

  2. test beginning to work

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    886b621 View commit details
    Browse the repository at this point in the history

  3. working implementation with server side prefetch of loaders for SSR +… 

    … rehydration
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    6953829 View commit details
    Browse the repository at this point in the history

  4. Fixed call to loader on first render

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    facdda4 View commit details
    Browse the repository at this point in the history

  5. Fixed tests and added SSR and browser render

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    296c67e View commit details
    Browse the repository at this point in the history

  6. Moved SSR render test to inferno-server

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    8f4b69a View commit details
    Browse the repository at this point in the history

  7. Shrink and move

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    70b0d3f View commit details
    Browse the repository at this point in the history

  8. Use async await on server

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    66b2dbc View commit details
    Browse the repository at this point in the history

  9. Fix tests

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    9759f3f View commit details
    Browse the repository at this point in the history

  10. renamed loaderData to initialData

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    58bdfc3 View commit details
    Browse the repository at this point in the history

  11. Pass match params to async loader

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    7a17f2a View commit details
    Browse the repository at this point in the history

  12. Move first invokation of loader to lifecycle hook where it belongs

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    e9e8697 View commit details
    Browse the repository at this point in the history

  13. The condition can be solved through recursion for readability and red… 

    …uced bundle size
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    5177eec View commit details
    Browse the repository at this point in the history

  14. Some tests working

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    02269b2 View commit details
    Browse the repository at this point in the history

  15. Fixed regression bugs

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    75bba0f View commit details
    Browse the repository at this point in the history

  16. Remove moved code

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    ff37740 View commit details
    Browse the repository at this point in the history

  17. Improve typing and structure components to be more similar. Added swi… 

    …tch test
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    b50c465 View commit details
    Browse the repository at this point in the history

  18. Added demo application to test inferno-router with async loading

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    ac30077 View commit details
    Browse the repository at this point in the history

  19. Added note on possibly false test

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    169691e View commit details
    Browse the repository at this point in the history

  20. unused props

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    5d72431 View commit details
    Browse the repository at this point in the history

  21. Demo: SSR (WIP) with resolving of loaders and using Parcel to transpi… 

    …le app on startup
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    2f8f2f0 View commit details
    Browse the repository at this point in the history

  22. Serve a proper SSR page to browser

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    3c822ab View commit details
    Browse the repository at this point in the history

  23. SSR and hydration

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    b031099 View commit details
    Browse the repository at this point in the history

  24. Moved invocation of loader to Router

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    b26fbc8 View commit details
    Browse the repository at this point in the history

  25. Fixed redirect issue that broke Switch tests

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    52fd289 View commit details
    Browse the repository at this point in the history

  26. Notes for investigation of request

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    6b5bd8d View commit details
    Browse the repository at this point in the history

  27. Demo using params in loader

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    2156a4c View commit details
    Browse the repository at this point in the history

  28. Added test with params

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    b1d9488 View commit details
    Browse the repository at this point in the history

  29. First, dumbed down, try at adding request param and AbortController t… 

    …o allow cancelling inflight fetch on consecutive navigation WIP
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    9757aa5 View commit details
    Browse the repository at this point in the history

  30. Add test for abort signal on nav

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    25405c4 View commit details
    Browse the repository at this point in the history

  31. Fix demo

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    d108767 View commit details
    Browse the repository at this point in the history

  32. Remove duplicate code in inferno-server

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    f5fbd2d View commit details
    Browse the repository at this point in the history

  33. Simplify inherited code

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    3f7826b View commit details
    Browse the repository at this point in the history

  34. Simplify again, Location objects return a href string

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    95abb27 View commit details
    Browse the repository at this point in the history

  35. Change deprecated call, cleanup and and typing

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    72e5768 View commit details
    Browse the repository at this point in the history

  36. Switch only renders first match so bailing out early

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    3c70029 View commit details
    Browse the repository at this point in the history

  37. Don't traverse deeper if Route doesn't match

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    46f9ecd View commit details
    Browse the repository at this point in the history

  38. Removed loader code in Switch since it is handled by Router now

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    f8b6ffc View commit details
    Browse the repository at this point in the history

  39. Change name to loaderData for individual match

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    65dd88a View commit details
    Browse the repository at this point in the history

  40. Fixed SSR-rendering and added base argument to traverseLoaders to all… 

    …ow creating fully qualified URI from route path during SSR (if one wants to use it in the loader for hybrid endpoints)
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    b8aff25 View commit details
    Browse the repository at this point in the history

  41. Remove unused imports

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    71e44a1 View commit details
    Browse the repository at this point in the history

  42. Remove unreachable code

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    8a3f0e6 View commit details
    Browse the repository at this point in the history

  43. Unused types

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    b439c8d View commit details
    Browse the repository at this point in the history

  44. Support subclassing Switch

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    ed050fc View commit details
    Browse the repository at this point in the history

  45. Send cancel signal in demo

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    c835a8e View commit details
    Browse the repository at this point in the history

  46. Fix issue where multiple nav clicks with loaders resolving out of ord… 

    …er wouldn't end up on the last clicked route
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    227f1a3 View commit details
    Browse the repository at this point in the history

  47. Support typing response from loader data/error helpers

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    fc4f326 View commit details
    Browse the repository at this point in the history

  48. Use cross-env for Win-compat

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    4ec8736 View commit details
    Browse the repository at this point in the history

  49. Fix loader signature in AboutPage.tsx to allow calls to be cancelled

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    65181d6 View commit details
    Browse the repository at this point in the history

  50. Fixed linting errors

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    4973fb2 View commit details
    Browse the repository at this point in the history

  51. Use custom resolver to allow parcel to choose correct bundle when pac… 

    …kaging
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    c62d650 View commit details
    Browse the repository at this point in the history

  52. Don't expose parentIsSwitch in exported function traverseLoaders sinc… 

    …e it is an implementation detail
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    2a7df6b View commit details
    Browse the repository at this point in the history

  53. Trigger rerender after promises have been resolved to make sure any p… 

    …ending renders are flushed
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    073370b View commit details
    Browse the repository at this point in the history

  54. Update test to make sure we don't get false passing (I have broken th… 

    …e library code to verify that test fails)
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    804f467 View commit details
    Browse the repository at this point in the history

  55. Missed a Switch check

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    a720c10 View commit details
    Browse the repository at this point in the history

  56. Remove parcel-resolver-inferno and use alias instead to pick transpil… 

    …ed dev version in demo
    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    d676724 View commit details
    Browse the repository at this point in the history

  57. Remove need for esModuleInterop and isolatedModules

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    9eac3f5 View commit details
    Browse the repository at this point in the history

  58. Update README for inferno-router

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    7f025fa View commit details
    Browse the repository at this point in the history

  59. Update docs

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    3a0148e View commit details
    Browse the repository at this point in the history

  60. Added link to demo and react-router loader docs

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    216b9fc View commit details
    Browse the repository at this point in the history

  61. Call .json() and .text() on fetch result automatically

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    ae36e0a View commit details
    Browse the repository at this point in the history

  62. Rephrase part about missing features vs. react-router@6

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    bd01ab0 View commit details
    Browse the repository at this point in the history

  63. Clarified which headers aren't exposed

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    e5703a7 View commit details
    Browse the repository at this point in the history

  64. Bump versions

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    3de7d0c View commit details
    Browse the repository at this point in the history

  65. Cleaned up demo code and added clarification

    @jhsware
    jhsware committed Apr 25, 2023
    Copy the full SHA
    f4a7efe View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Convert tests to Typescript

    @jhsware
    jhsware committed Apr 26, 2023
    Copy the full SHA
    a821567 View commit details
    Browse the repository at this point in the history

  2. Updated package-lock.json

    @jhsware
    jhsware committed Apr 26, 2023
    Copy the full SHA
    37ba7ed View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Store spy in variable to avoid type error and harmonise naming of sai… 

    …d variables
    @jhsware
    jhsware committed May 13, 2023
    Copy the full SHA
    54581c7 View commit details
    Browse the repository at this point in the history

  2. Improve test of passing Location obj to Link

    @jhsware
    jhsware committed May 13, 2023
    Copy the full SHA
    261af08 View commit details
    Browse the repository at this point in the history

  3. Fix linting errors

    @jhsware
    jhsware committed May 13, 2023
    Copy the full SHA
    a9f9eaa View commit details
    Browse the repository at this point in the history

  4. Final fix

    @jhsware
    jhsware committed May 13, 2023
    Copy the full SHA
    ccb8dc0 View commit details
    Browse the repository at this point in the history

  5. Change type of to property so it is compatible with tests and parse… 

    …Path
    @jhsware
    jhsware committed May 13, 2023
    Copy the full SHA
    e5b0673 View commit details
    Browse the repository at this point in the history