Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make translations publishable #38

Closed
markwalet opened this issue Mar 12, 2019 · 2 comments
Closed

Make translations publishable #38

markwalet opened this issue Mar 12, 2019 · 2 comments

Comments

@markwalet
Copy link
Contributor

To make the package look more like Laravel Nova, I want to propose the following changes.

  • Add a resources/lang/en.json file with all translation keys that are used. (The one in the readme are out of date)
  • Load them and make them publishable via the service provider.
  • Remove the translation keys from the readme.
  • Add a tutorial on how to publish the translation files.

I already started working on a PR for this issue.
@markwalet markwalet mentioned this issue Mar 12, 2019
Merged
@Krato Krato closed this as completed in #39 Mar 19, 2019
@Krato
Copy link
Collaborator

Krato commented Mar 19, 2019

Hello @markwalet. I just revert your pull request. For now is not able to load translations into nova: laravel/nova-issues#982

@aliwesome
Copy link

@Krato I think that problem is fixed now. can we have that PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Krato @markwalet @aliwesome