Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignite #75

Open
supercoolspy opened this issue Jun 26, 2024 · 1 comment
Open

Add support for ignite #75

supercoolspy opened this issue Jun 26, 2024 · 1 comment
Labels
enhancement New feature or request new package Requests or adds a new package package Topic: Deals with nix-minecraft packages

Comments

@supercoolspy
Copy link

Ignite is a server mixin library comparable with paper and spigot. It would be cool to have a boolean option to enable it.

@Infinidoge
Copy link
Owner

Since ignite is a Java Agent, this would probably be better implemented as generic Java Agent handling, with a relevant package in nix-minecraft to make it easier to install. Wouldn't quite be a boolean option, but javaAgents = [ ignite ]; wouldn't be that difficult to use, and it would make using other Java Agents (like unsup) easier too.

If you don't want to wait, you can use

let
  ignite = fetchurl {
    url = "https://github.com/vectrix-space/ignite/releases/download/v1.0.1/ignite.jar";
    sha256 = "hash goes here";
  };
in {
  ... # (These are the server options)
  jvmArgs = "... -javaagent:${ignite}";
}

I'd like to avoid module options for server-specific things, because the server module is supposed to be server-agnostic. That said, a package override for paper/spigot to automatically include ignite would be possible.

@Infinidoge Infinidoge added the enhancement New feature or request label Jun 26, 2024
@Infinidoge Infinidoge added package Topic: Deals with nix-minecraft packages new package Requests or adds a new package labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new package Requests or adds a new package package Topic: Deals with nix-minecraft packages
Projects
None yet
Development

No branches or pull requests

2 participants