Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask]: Implement ElasticSearch client #954

Closed
yangjie407 opened this issue Apr 8, 2024 · 3 comments
Closed

[Subtask]: Implement ElasticSearch client #954

yangjie407 opened this issue Apr 8, 2024 · 3 comments

Comments

@yangjie407
Copy link
Contributor

Parent Issue

Parent issue: #951

Detail of Subtask

The ElasticSearch client is inherited from BaseClient, and implements the functions(upload, search) using ElasticSearch python SDK.

Describe implementation you've considered

No response
@Rassyan
Copy link

Rassyan commented Apr 9, 2024

I'm interested in the performance comparison between Infinity and ES. Is external contribution needed for this issue?

@yangjie407
Copy link
Contributor Author

yangjie407 commented Apr 11, 2024 •
edited

I'm interested in the performance comparison between Infinity and ES. Is external contribution needed for this issue?

If you wanna compare the performance between ES and infinity, you can implement the ES client interface. I will upload a preliminary qdrant client later for your reference. We look forward to your help.
Issue: #951

@JinHai-CN
Copy link
Contributor

@Rassyan Qdrant client is implemented. #969

@JinHai-CN JinHai-CN mentioned this issue Apr 16, 2024
Merged
1 task
JinHai-CN pushed a commit that referenced this issue Apr 16, 2024
@yangjie407
implement elasticsearch client (#1029)
e9cf3c8 
### What problem does this PR solve?

Implement elasticsearch client for benchmark.

Issue link:#953 #954

### Type of change

- [x] New Feature (non-breaking change which adds functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rassyan @JinHai-CN @yangjie407