Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handling of commit timestamps #514

Closed
wants to merge 1 commit into from

Conversation

loloxwg
Copy link
Member

@loloxwg loloxwg commented Feb 1, 2024

The commit timestamps handling has been revised to better track the max commit timestamps in GlobalCatalogDeltaEntry. Previously, any mismatch between commit timestamps would result in an error. Now, such discrepancies are handled by injecting the segment entries, which have commit timestamps greater than max_commit_ts, back into the global_catalog_delta_entry_ list.

What problem does this PR solve?

Add corresponding issue link with summary if exists -->

Issue link:

What is changed and how it works?

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (knn performance test)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

The commit timestamps handling has been revised to better track the max commit timestamps in GlobalCatalogDeltaEntry. Previously, any mismatch between commit timestamps would result in an error. Now, such discrepancies are handled by injecting the segment entries, which have commit timestamps greater than max_commit_ts, back into the global_catalog_delta_entry_ list.
@yingfeng yingfeng added the ci PR can be test label Feb 1, 2024
@loloxwg loloxwg closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants