HRCPP-126 Segfault with cluster and connectionPool with minIdle > 0 #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/HRCPP-126
Moved the responsability of issuing the startup ping from the TransportObjectFactory to the TcpTransportFactory.
This avoids issues related to TcpTransportFactory.servers being updated as a result of a new topology being received in the ping response while iterating over the entries in TcpTransportFactory.servers.
The initial cause of the segfault was: the servers.clear() call in updateServers calls the destructor of the InetSocketAddress passed as parameter to makeObject() but the object is used again before makeObject() returns.