Hrcpp 402/near cache gtest #306
Conversation
rigazilla
force-pushed
the
HRCPP-402/near_cache_gtest
branch
2 times, most recently
from
57335f5
to
de92703
Compare
rigazilla
force-pushed
the
HRCPP-402/near_cache_gtest
branch
2 times, most recently
from
726c0ad
to
fa2c741
Compare
There was a problem hiding this comment.
@rigazilla there are some formatting issues in a lot of the files. I can also see that the tests in NearCacheStaleReadsTest map to the tests in the "client.hotrod.near.AvoidStaleNearCacheReadsTest" class in the Java test suite. I'm not sure which Java class the tests in NearCacheMultiClientTest map to. It also seems like there are some other tests from the Java test suite that haven't been implemented here? (i.e. eviction, failover, etc.)
test/query_proto/bank-xunit.proto
Outdated
| @@ -0,0 +1,158 @@ | |||
| package sample_bank_account; | |||
There was a problem hiding this comment.
To avoid messages like this during the build:
[libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax specified for the proto file: bank-xunit.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
The proto files should contain a line like: syntax = "proto3"; or syntax = "proto2";.
|
|
||
| void NearCacheTest::SetUp() { | ||
| if (NearCacheTest::remoteCacheManager == nullptr){ | ||
| ConfigurationBuilder builder; |
|
|
||
| TEST_F(NearCacheTest, ClientsInvalidatedTest) { | ||
| NearCacheTest::remoteCacheManager->start(); | ||
| BasicMarshaller<std::string> *km1 = new BasicMarshaller<std::string>(); |
|
|
||
| void NearCacheStaleReadsTest::SetUp() { | ||
| if (NearCacheStaleReadsTest::remoteCacheManager == nullptr){ | ||
| ConfigurationBuilder builder; |
There was a problem hiding this comment.
There are also indentation issues in this file
| std::unique_ptr<infinispan::hotrod::RemoteCacheManager> NearCacheTest::remoteCacheManager; | ||
|
|
||
| void waitFor(const std::function<bool()> &func, long waitTime = 1000, int pollInterval = 100); | ||
| /*void waitFor(const std::function<bool()> &func, long waitTime = 1000, int pollInterval = 100) |
xunit-test/QueryTest/CMakeLists.txt
Outdated
| @@ -0,0 +1,31 @@ | |||
| file(GLOB SRCS *.cpp) | |||
There was a problem hiding this comment.
Should the QueryTest changes be in this PR or in #305?
rigazilla
force-pushed
the
HRCPP-402/near_cache_gtest
branch
from
6587424
to
732ab53
Compare
rigazilla
force-pushed
the
HRCPP-402/near_cache_gtest
branch
from
732ab53
to
c49de48
Compare
|
@alanfx cleaned up and rebased to not contain query tests. |
|
@rigazilla actually, I'd just like to keep https://issues.jboss.org/browse/HRCPP-402 open and add comments there. I'm not sure if the failover tests will get implemented, but the eviction ones should. The changes in this PR look good to me, so let me know if that works for you. |
|
@rigazilla No problem. I have merged this PR, and added a comment to the JIRA |
near cache xunit test suite
https://issues.jboss.org/browse/HRCPP-402