Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HRCPP-466 Improved error handling #327

Merged
merged 2 commits into from Mar 22, 2018
Merged

HRCPP-466 Improved error handling #327

merged 2 commits into from Mar 22, 2018

Conversation

rigazilla
Copy link
Contributor

@alanfx
Copy link
Contributor

alanfx commented Mar 22, 2018

@rigazilla this looks good to me, but I am wondering if there is a way to add a test for this change?

@rigazilla
Copy link
Contributor Author

@alanfx I can't imagine an easy way to make the AcquireCredentialsHandle call fails. The only failing configuration I met is described here, but requires an ad hoc manual setup.

@alanfx
Copy link
Contributor

alanfx commented Mar 22, 2018

@rigazilla Hm, ok. I'll go ahead and merge this change then. Checking return values is always a good thing!

@alanfx alanfx merged commit 141092e into infinispan:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rigazilla @alanfx