Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-7062 - Cassandra cache store: Upgrade to latest cassandra and Da… #8

Closed
wants to merge 1 commit into from

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Sep 28, 2016

…tastax driver

Hi all,

This PR is related to: https://issues.jboss.org/browse/ISPN-7062

Thanks,
Andrea

@burmanm
Copy link

burmanm commented Oct 10, 2016

Newest Cassandra is 3.9, but it might be recommendable to use the 3.0.9 version instead if stability is important (unless newer features of 3.x are used)

@oscerd
Copy link
Contributor Author

oscerd commented Oct 10, 2016

Yeah, I guess you're right. 3.9 is a tick-tock release. I'm upgrading the PR :-)

@oscerd
Copy link
Contributor Author

oscerd commented Oct 10, 2016

At least we should stay with 3.2.

@tristantarrant
Copy link
Member

I agree with @burmanm: let's use 3.0.10

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

I guess this is will need some work on the code.

@burmanm
Copy link

burmanm commented Feb 1, 2017

Is there something in the code that would require 3.x? I didn't see such commits and the only major feature missing from 3.0.x is SASI (but SASI isn't used here).

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

Not sure, but If you try to build the current code with 3.0.10 the build will fail during test, because the cassandra client didn't connect to the Cassandra instance. That's why I was suggesting to use 3.2.

Anyway I'll take a deeper look when I'll have time.

@burmanm
Copy link

burmanm commented Feb 1, 2017

Ah, try updating the cassandra-driver to newer version in the branch (but keep it separate from the Cassandra version, they're two different things). 3.0.6 is the newest driver version, that should at least work (we use 3.0.5 in the Hawkular to connect to 3.0.x Cassandra versions - but we just haven't noticed the new version 3.0.6).

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

Tested with cassandra 3.0.10 and cassandra driver 3.0.5 and 3.0.6 but no luck.

@burmanm
Copy link

burmanm commented Feb 1, 2017

What's the error? It shouldn't be the versions.

@burmanm
Copy link

burmanm commented Feb 1, 2017

Sounds more like environment issue ;)

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

It was a problem with a new option in cassandra.yaml, I'll push a new PR in minutes :-)

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

thanks @burmanm

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

PR updated

@oscerd
Copy link
Contributor Author

oscerd commented Feb 1, 2017

@tristantarrant @burmanm let me know what you think

@tristantarrant
Copy link
Member

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants