Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of the process method #8

Closed
wants to merge 5 commits into from

Conversation

kurtymckurt
Copy link
Contributor

No description provided.

@kurtymckurt
Copy link
Contributor Author

Added updating the mongo cache store to the 8.1 api.

@kurtymckurt
Copy link
Contributor Author

Wrote a jmh benchmark test.
https://github.com/kurtymckurt/infinispan-cachestore-mongodb-benchmark/blob/master/test/src/main/java/org/sample/MyBenchmark.java

Below are the results comparing the new version vs the previous.

8.1.2.Final

Result "testMethod":
27.943 ±(99.9%) 0.272 ops/s [Average](min, avg, max) = (25.899, 27.943, 28.712), stdev = 0.549
CI (99.9%): [27.671, 28.215](assumes normal distribution)

Run complete. Total time: 00:02:23

Benchmark Mode Cnt Score Error Units
MyBenchmark.testMethod thrpt 50 27.943 ± 0.272 ops/s

6.0.2.Final

Result "testMethod":
3.526 ±(99.9%) 0.126 ops/s [Average](min, avg, max) = (2.983, 3.526, 3.809), stdev = 0.255
CI (99.9%): [3.400, 3.652](assumes normal distribution)

Run complete. Total time: 00:02:36

Benchmark Mode Cnt Score Error Units
MyBenchmark.testMethod thrpt 50 3.526 ± 0.126 ops/s

@gustavocoding
Copy link

Hi @kurtymckurt, nice improvement!
There is just a config related test failure in https://travis-ci.org/infinispan/infinispan-cachestore-mongodb/builds/112806527, could you take a look?

@kurtymckurt
Copy link
Contributor Author

@gustavonalle I believe I fixed that test. Sorry about that.

@gustavocoding
Copy link

@kurtymckurt fixed, but unfortunately the latest commits introduced other failures

@kurtymckurt
Copy link
Contributor Author

Yeah, I added a stop method to clean up the MongoClient connections for the jmh test and that causes problems with the other tests. I added a proper startup for it now.

@gustavocoding
Copy link

Integrated, thanks @kurtymckurt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants