ISPN-12370 Digest authentication and form login #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
force-pushed
the
form-login
branch
4 times, most recently
from
0c7232c
to
2946515
Compare
oraNod
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
LGTM @karesti I pushed a commit with some doc edits. Keycloak auth redirect works nicely.
One glitch that I couldn't figure out. In Support.tsx the brandname attribute does not get substituted. It contains const brandname = t('brandname.brandname'); and everything looks OK.
But if you add {{brandname}} to the text strings the variable doesn't get populated during compile. I reworded to get around it though so no biggie.
* Log in implemented * Log out implemented * Refactoring of the services to get an IoC model * Upgrade e2e to 12.0.0.Final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-12370
Needs master branch when PR merged or my branch
infinispan/infinispan#9016