Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-11492 Cluster and Cache enable/disable rebalancing #159

Merged

Conversation

karesti
Copy link
Collaborator

@karesti karesti commented Sep 16, 2021

This PR includes for facility and testing 3 rebalancing features.

Only for admins (observer should not access this feature for example)

  • Enable/disable rebalancing at cluster level
  • Enable/disable rebalancing at cache level if rebalancing is enabled at cluster level.

For all the users

  • Display a "rebalancing off" badge in the cache list when rebalancing is enabled at cluster level and the cache in the list has rebalancing disabled.

ISSUE https://issues.redhat.com/browse/ISPN-11491

Cluster Level

Screenshot 2021-09-16 at 23 43 35

ISSUE https://issues.redhat.com/browse/ISPN-11492

Cache Level

Screenshot 2021-09-16 at 23 43 42

>

If rebalancing is globally disabled, the cache detail does not display anything

Cluster View List of Caches. When the cache has rebalancing disabled, display a badge.

ISSUE https://issues.redhat.com/browse/ISPN-11493

Screenshot 2021-09-17 at 16 33 14

Depends on this PR: infinispan/infinispan#9519

@karesti karesti force-pushed the ISPN-11492-enable-disable-rebalancing branch 2 times, most recently from 896598b to c10e8bd Compare September 16, 2021 22:18
@karesti karesti force-pushed the ISPN-11492-enable-disable-rebalancing branch 2 times, most recently from 7716e6c to 2646f42 Compare September 17, 2021 14:30
@karesti karesti force-pushed the ISPN-11492-enable-disable-rebalancing branch from 2646f42 to d39648a Compare September 17, 2021 14:42
@karesti karesti removed the request for review from diegolovison September 17, 2021 14:51
Copy link
Member

@danberindei danberindei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a little nitpick: it seems to me that there must be a better place for "cluster" functionality than in dataContainerService.ts

@karesti
Copy link
Collaborator Author

karesti commented Sep 20, 2021

Looks good, just a little nitpick: it seems to me that there must be a better place for "cluster" functionality than in dataContainerService.ts

dataContainer file can be renamed if you want to, since this is a naming we chose to use back in the console creation. but the actual rest api call is related to all the cache-manager api calls. I rather leave it there for now

@karesti karesti merged commit 39e32a8 into infinispan:main Sep 20, 2021
@karesti karesti deleted the ISPN-11492-enable-disable-rebalancing branch September 20, 2021 16:00
@danberindei
Copy link
Member

dataContainer file can be renamed if you want to, since this is a naming we chose to use back in the console creation. but the actual rest api call is related to all the cache-manager api calls. I rather leave it there for now

That's fine Katia, you can rename it when you feel like cleaning house post 13.0

dpanshug pushed a commit to dpanshug/infinispan-console that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants