ISPN-13691 Feature form for persisted caches

[dpanshug]

Feature form for Persisted Cache

[ryanemerson]

My review has focused on the templates. I haven't looked at the Typescript code.

IMO the templates used in the Wizard should provide the minimal configuration required for the store to function in it's most common use-case. I imagine a lot of users will attempt to utilise the templates without modification, so it's important that we don't include "extra" configuration such as "write-behind" that aren't applicable to the most common use-case.

[dpanshug]

@ryanemerson new commit pushed. updated your suggestions, and now cache creation is also working in the last step.

[ryanemerson]

Just the one outstanding comment to address and your branch needs rebasing as there are conflicts that prevent the PR from being mergeable.

[dpanshug]

@ryanemerson Branch rebased and the last suggestion was also done 👍

[dpanshug]

@oraNod please review the labels :)

[dpanshug]

@ryanemerson got this error while creating persistent cache with "rocks-db" storage

config:

{
  "distributed-cache": {
    "mode": "SYNC",
    "owners": 1,
    "statistics": true,
    "encoding": {
      "media-type": "application/x-protostream"
    },
    "locking": {
      "isolation": "REPEATABLE_READ"
    },
    "persistence": {
      "rocks-db": {
        "path": "rocksdb/data",
        "expiration": {
          "path": "rocksdb/expired"
        }
      }
    }
  }
}

[karesti]

@dipguptaredhat the persistence stores are available only when the proper connectors are available in the server. I'm reviewing the PR from my side

[ryanemerson]

got this error while creating persistent cache with "rocks-db" storage

I think the store parent element should be "rocksdb-store"

[karesti]

@dipguptaredhat @ryanemerson @oraNod I'm on this PR

[karesti]

@dipguptaredhat @oraNod I simplified after speaking with Ryan since having more than one store is VERY UNLIKE TO HAPEN. In general 1 cache = 1 store, so configuring multiple stores is confusing and complicated.
I also simplified the templates since the "table-store" and so on are part of the persistent store config and should not be in the end but in the editor as an example

[karesti]

needs some extra checks. for example if the config in the editor is json for persistence but the json is not valid, we should not be able to 'next'.