Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-13916 Pagination and extra fixes #228

Merged
merged 1 commit into from Jul 13, 2022
Merged

ISPN-13916 Pagination and extra fixes #228

merged 1 commit into from Jul 13, 2022

Conversation

karesti
Copy link
Collaborator

@karesti karesti commented Jul 10, 2022 •
edited

https://issues.redhat.com/browse/ISPN-13916

  • Cancel button on edit works correctly
  • Create adapted to PTF4 forms
  • Labels into properties

@dpanshug
Copy link
Collaborator

One scenario not working, @andyuk1986 mentioned in the issue,

There are 11 schemas available. I am clicking next and see 11-11 of 11 and I can see the last schema. Then from this page I change the number of schemas to be shown on the page, i.e. 20 per page. At this moment it becomes: 21 11 of 11 and shows "No schemas yet". E.g. the same scenario in data container page works properly, e.g. for 17 available caches when the number of viewed caches is changed on the last 11-17 of 17 page to 20 per page, it automatically shows all caches 1 17 of 17.

@karesti
ISPN-13916 Pagination and extra fixes
54b1031 
* Cancel button on edit works correctly
* Create adapted to PTF4 forms
* Labels into properties
@karesti karesti force-pushed the refactor-proto-caches-form branch from 8f02115 to 54b1031 Compare July 12, 2022 15:50
@karesti
Copy link
Collaborator Author

karesti commented Jul 12, 2022

@dipguptaredhat fixed

andyuk1986
andyuk1986 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@andyuk1986 andyuk1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipguptaredhat for pointing out the issue described in JIRA. Currently everything works fine. Approved from my side.

@dpanshug dpanshug merged commit d4b753b into infinispan:main Jul 13, 2022
@karesti karesti deleted the refactor-proto-caches-form branch July 13, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyuk1986 andyuk1986 andyuk1986 approved these changes

@dpanshug dpanshug dpanshug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karesti @dpanshug @andyuk1986