Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14000 Wizard indexing protobuf list #234

Merged
merged 3 commits into from Aug 2, 2022
Merged

ISPN-14000 Wizard indexing protobuf list #234

merged 3 commits into from Aug 2, 2022

Conversation

dpanshug
Copy link
Collaborator

@dpanshug dpanshug commented Jul 20, 2022 •
edited

@dpanshug dpanshug requested a review from karesti July 20, 2022 14:14
karesti
karesti requested changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes discussed in the call

@dpanshug dpanshug force-pushed the ISPN-14000-wizard-indexing-configuration-list branch from 06abe5f to c2ff5ff Compare July 25, 2022 05:34
@dpanshug dpanshug force-pushed the ISPN-14000-wizard-indexing-configuration-list branch from c2ff5ff to 8d0b0d6 Compare July 25, 2022 05:47
karesti
karesti requested changes Jul 27, 2022
View reviewed changes
src/app/Caches/Create/Features/IndexedCacheConfigurator.tsx Outdated Show resolved Hide resolved
src/app/assets/languages/en.json Outdated Show resolved Hide resolved
src/services/protobufService.ts Outdated Show resolved Hide resolved
src/services/protobufService.ts Outdated Show resolved Hide resolved
src/app/utils/filterProtobufSchema.ts Outdated Show resolved Hide resolved
src/app/services/protobufHook.ts Outdated Show resolved Hide resolved
src/app/services/protobufHook.ts Outdated Show resolved Hide resolved
src/app/Caches/Create/FeaturesSelector.tsx Outdated Show resolved Hide resolved
src/app/Caches/Create/Features/IndexedCacheConfigurator.tsx Outdated Show resolved Hide resolved
karesti
karesti requested changes Jul 28, 2022
View reviewed changes
src/app/Caches/Create/Features/FeatureAlert.tsx Outdated Show resolved Hide resolved
src/app/Caches/Create/Features/IndexedCacheConfigurator.tsx Outdated Show resolved Hide resolved
src/app/Caches/Create/Features/IndexedCacheConfigurator.tsx Outdated Show resolved Hide resolved
src/app/assets/languages/en.json Outdated Show resolved Hide resolved
@dpanshug dpanshug force-pushed the ISPN-14000-wizard-indexing-configuration-list branch from f2530f1 to 4c22a78 Compare August 1, 2022 06:41
@andyuk1986 andyuk1986 merged commit 0efc70e into infinispan:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti requested changes

@andyuk1986 andyuk1986 andyuk1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpanshug @karesti @andyuk1986