Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-11660 Cache Detail: data distribution +5 nodes #254

Merged
merged 3 commits into from Oct 5, 2022
Merged

ISPN-11660 Cache Detail: data distribution +5 nodes #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0289cf
ISPN-11660 Cache Detail: data distribution +5 nodes
dpanshug Aug 26, 2022
dd876d6
ISPN-11660 Fix stats in caches and change layout
karesti Oct 4, 2022
84dc6dd
ISPN-11660 Updated e2e test for cache-metrics
dpanshug Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions cypress/e2e/cache-metrics.cy.js
View file
Open in desktop
Expand Up @@ -3,26 +3,26 @@ describe('Cache Metrics Overview', () => {
cy.login(Cypress.env("username"), Cypress.env("password"), '/cache/people');
//Check for Labels
cy.contains('Metrics (Enabled)').click();
cy.contains('Current number of entries');
cy.contains('Approximate number of entries');
cy.contains('Minimum number of nodes');
cy.contains('Size of cache in off-heap memory');
cy.contains('Size of cache in heap memory');

// Check for data greater than -1
cy.get('dt[aria-label="view-cache-metrics-size"]').invoke('text').then(parseFloat).should('be.gt', -1)
cy.get('dt[aria-label="view-cache-approximate-unique-entries"]').invoke('text').then(parseFloat).should('be.gt', -1)
cy.get('dt[aria-label="view-cache-metrics-nodes"]').invoke('text').then(parseFloat).should('be.gt', -1)
})

it('successfully checks cache metrics for heap memory', () => {
cy.login(Cypress.env("username"), Cypress.env("password"), '/cache/heap-test');
cy.contains('Metrics (Enabled)').click();
cy.contains('Size of cache in heap memory');
cy.get('dt[aria-label="view-cache-metrics-heap"]').invoke('text').then(parseFloat).should('be.gt', -1)

})

it('successfully checks cache metrics for off-heap memory', () => {
cy.login(Cypress.env("username"), Cypress.env("password"), '/cache/off-heap-test');
cy.contains('Metrics (Enabled)').click();
cy.contains('Size of cache in off-heap memory');
cy.get('dt[aria-label="view-cache-metrics-off-heap"]').invoke('text').then(parseFloat).should('be.gt', -1)
})

Expand Down
286 changes: 111 additions & 175 deletions src/app/Caches/CacheMetrics.tsx
View file
Open in desktop

Large diffs are not rendered by default.

116 changes: 116 additions & 0 deletions src/app/Caches/DataAccessChart.tsx
View file
Open in desktop
@@ -0,0 +1,116 @@
import React from 'react';
import {
Card,
CardBody,
CardFooter,
CardTitle,
ExpandableSection,
List,
ListComponent,
ListItem, OrderType
} from '@patternfly/react-core';
import {ChartDonut, ChartThemeColor} from '@patternfly/react-charts';
import {useTranslation} from 'react-i18next';
import displayUtils from "@services/displayUtils";
import {PopoverHelp} from "@app/Common/PopoverHelp";

const DataAccessChart = (props: {
stats: CacheStats;
}) => {
const { t } = useTranslation();
const brandname = t('brandname.brandname');
const all =
props.stats.hits +
props.stats.retrievals +
props.stats.remove_hits +
props.stats.remove_misses +
props.stats.stores +
props.stats.misses +
props.stats.evictions;

return (
<Card>
<CardTitle>
<PopoverHelp name={'pop-over-data-access-chart-help'}
label={t('caches.cache-metrics.data-access-title')}
text={t('caches.cache-metrics.data-access-title')}
content={
<List component={ListComponent.ol} type={OrderType.number}>
<ListItem>{t('caches.cache-metrics.data-access-hits-info')}</ListItem>
<ListItem>{t('caches.cache-metrics.data-access-misses-info')}</ListItem>
<ListItem>{t('caches.cache-metrics.data-access-stores-info')}</ListItem>
<ListItem>{t('caches.cache-metrics.data-access-retrievals-info')}</ListItem>
<ListItem>{t('caches.cache-metrics.data-access-remove-hits-info')}</ListItem>
<ListItem>{t('caches.cache-metrics.data-access-remove-misses-info')}</ListItem>
<ListItem>{t('caches.cache-metrics.data-access-evictions-info')}</ListItem>
</List>}
/>
</CardTitle>
<CardBody>
<div style={{ width: '100%', height:'480px' }}>
<ChartDonut
width={600}
height={400}
constrainToVisibleArea={true}
data={[
{ x: t('caches.cache-metrics.data-access-hits'), y: props.stats.hits },
{ x: t('caches.cache-metrics.data-access-misses'), y: props.stats.misses },
{ x: t('caches.cache-metrics.data-access-stores'), y: props.stats.stores },
{ x: t('caches.cache-metrics.data-access-retrievals'), y: props.stats.retrievals },
{ x: t('caches.cache-metrics.data-access-remove-hits'), y: props.stats.remove_hits },
{ x: t('caches.cache-metrics.data-access-remove-misses'), y: props.stats.remove_misses },
{ x: t('caches.cache-metrics.data-access-evictions'), y: props.stats.evictions },
]}
labels={({ datum }) =>
`${datum.x}:${displayUtils.formatNumber(
(datum.y * 100) / all
)}%`
}
legendData={[
{
name: t('caches.cache-metrics.data-access-hits') + ': ' + displayUtils.formatNumber(props.stats.hits),
},
{
name: t('caches.cache-metrics.data-access-misses') + ': ' + displayUtils.formatNumber(props.stats.misses),
},
{
name: t('caches.cache-metrics.data-access-stores') + ': ' + displayUtils.formatNumber(props.stats.stores),
},
{
name:
t('caches.cache-metrics.data-access-retrievals') + ': ' +
displayUtils.formatNumber(props.stats.retrievals),
},
{
name:
t('caches.cache-metrics.data-access-remove-hits') + ': ' +
displayUtils.formatNumber(props.stats.remove_hits),
},
{
name:
t('caches.cache-metrics.data-access-remove-misses') + ': ' +
displayUtils.formatNumber(props.stats.remove_misses),
},
{
name:
t('caches.cache-metrics.data-access-evictions') + ': ' + displayUtils.formatNumber(props.stats.evictions),
},
]}
legendOrientation={'vertical'}
legendPosition={'bottom'}
padding={{
bottom: 160,
left: 0,
right: 0, // Adjusted to accommodate legend
top: 0,
}}
title={displayUtils.formatBigNumber(all)}
themeColor={ChartThemeColor.multiOrdered}
/>
</div>
</CardBody>
</Card>
);
};

export { DataAccessChart };
146 changes: 0 additions & 146 deletions src/app/Caches/DataDistribution.tsx
View file
Open in desktop

This file was deleted.