-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-14130 Add the memory option in the data Distribution chart #266
ISPN-14130 Add the memory option in the data Distribution chart #266
Conversation
005d284
to
2df7de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is something with the formatter of the code that is not ok.
could you please run prettier? npm run format
f27871f
to
9e1dd42
Compare
@karesti code might be changing because of prettier formatting, will create another PR for improving it in other files also. |
9e1dd42
to
03fbe46
Compare
@dpanshug needs rebase |
1c47d6b
to
57e0143
Compare
@dpanshug did you do any changes on this PR ? |
57e0143
to
f0470c6
Compare
I've pushed the changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing the feature where the endpoint answers
[
{
"node_name": "3803a7d55fbe-10729",
"node_addresses": [
"172.17.0.2:7800"
],
"memory_entries": 1,
"total_entries": 1,
"memory_used": 104
}
]
And nothing is displayed. I added one entry to a cache with this config:
Cache config
{
"vvbvbvvbb": {
"distributed-cache": {
"owners": "1",
"mode": "SYNC",
"statistics": true,
"encoding": {
"key": {
"media-type": "application/x-protostream"
},
"value": {
"media-type": "application/x-protostream"
}
},
"locking": {
"isolation": "REPEATABLE_READ"
},
"memory": {
"max-size": "56MB",
"when-full": "REMOVE"
}
}
}
}
@karesti I've updated the validation for displaying memory_used, now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase please!
e51365b
to
fe7da6b
Compare
https://issues.redhat.com/browse/ISPN-14130