Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.x] ISPN-14246 Query metrics tooltip refactoring #291

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[14.x] ISPN-14246 Query metrics tooltip refactoring #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions src/app/Caches/Query/QueryMetrics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, {useState} from 'react';
import {
Button,
ButtonVariant,
Expand All @@ -18,21 +18,20 @@ import {
TextListVariants,
TextVariants
} from '@patternfly/react-core';
import { TableErrorState } from '@app/Common/TableErrorState';
import { ClearQueryMetrics } from '@app/Caches/Query/ClearQueryMetrics';
import { useTranslation } from 'react-i18next';
import { ConsoleServices } from '@services/ConsoleServices';
import { useConnectedUser } from '@app/services/userManagementHook';
import { ConsoleACL } from '@services/securityService';
import { useSearchStats } from '@app/services/statsHook';
import { CustomCardTitle } from '@app/Common/CustomCardTitle';
import {TableErrorState} from '@app/Common/TableErrorState';
import {ClearQueryMetrics} from '@app/Caches/Query/ClearQueryMetrics';
import {useTranslation} from 'react-i18next';
import {ConsoleServices} from '@services/ConsoleServices';
import {useConnectedUser} from '@app/services/userManagementHook';
import {ConsoleACL} from '@services/securityService';
import {useSearchStats} from '@app/services/statsHook';
import {PopoverHelp} from "@app/Common/PopoverHelp";

/**
* Query stats for indexed caches only
*/
const QueryMetrics = (props: { cacheName: string }) => {
const { t } = useTranslation();
const brandname = t('brandname.brandname');
const { connectedUser } = useConnectedUser();
const { stats, loading, error, setLoading } = useSearchStats(props.cacheName);

Expand Down Expand Up @@ -131,9 +130,11 @@ const QueryMetrics = (props: { cacheName: string }) => {
<CardTitle>
<Level id={'query-stats'}>
<LevelItem>
<CustomCardTitle
title={'Query statistics'}
toolTip={'Average time, in nanoseconds, for queries on this cache.'}
<PopoverHelp
name="query-metrics"
label={t('caches.query.query-metrics-title')}
content={t('caches.query.query-metrics-tooltip')}
text={t('caches.query.query-metrics-title')}
/>
</LevelItem>
{buildClearStatsButton()}
Expand Down
2 changes: 2 additions & 0 deletions src/app/assets/languages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,8 @@
"add-entry-form-value-type-select-label": "Select Value Content Type"
},
"query": {
"query-metrics-title": "Query metrics",
"query-metrics-tooltip": "Average time, in nanoseconds, for queries on this cache.",
"button-clear-query-stats": "Clear all stats",
"stat-max": "Max",
"stat-count": "Count",
Expand Down