Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14230 Download server report from cluster membership list #334

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

dpanshug
Copy link
Collaborator

  • Action added to download server report.
  • Table changed to TableComposable
  • Labels exported

https://issues.redhat.com/browse/ISPN-14230

@dpanshug dpanshug requested a review from karesti March 31, 2023 10:54
src/app/ClusterStatus/ClusterStatus.tsx Outdated Show resolved Hide resolved
src/services/serverService.ts Outdated Show resolved Hide resolved
@dpanshug
Copy link
Collaborator Author

dpanshug commented Apr 4, 2023

One thing I've noticed, downloaded reports from server ./run-server-for-e2e.sh are not extractable

Whereas it's working fine with server 15.0.0-SNAPSHOT

@andyuk1986 can you check pls.

@dpanshug dpanshug requested a review from karesti April 4, 2023 09:27
@karesti
Copy link
Collaborator

karesti commented Apr 5, 2023

@jabolina any clue with @dpanshug issue ?

@andyuk1986
Copy link
Collaborator

@dpanshug what version of server do you use when running ./run-server-for-e2e.sh ? From my understanding this is ISPN 15.x feature, so you need to set 2 new variables which I have introduced in one of my last PRs for being able to run this scrip with ispn-15 server.

@dpanshug
Copy link
Collaborator Author

@dpanshug what version of server do you use when running ./run-server-for-e2e.sh ? From my understanding this is ISPN 15.x feature, so you need to set 2 new variables which I have introduced in one of my last PRs for being able to run this scrip with ispn-15 server.

I am running it on main branch i.e. 15.x, with exporting both variables EXISTING_SERVER_PATH & ZIP_NAME.

@andyuk1986
Copy link
Collaborator

Let me check it out

@andyuk1986
Copy link
Collaborator

@dpanshug @karesti seems that when we run the maven command to install the latest console changes to the server, i.e. build the console and copy the dist to the static directory of the already running server, then the generated report is corrupted. But if we will restart the server after that action, then the server is generated normally. Maybe we need to make some changes to script and maven commands so that later when tests are running we get normally generated report?

@dpanshug
Copy link
Collaborator Author

@dpanshug @karesti seems that when we run the maven command to install the latest console changes to the server, i.e. build the console and copy the dist to the static directory of the already running server, then the generated report is corrupted. But if we will restart the server after that action, then the server is generated normally. Maybe we need to make some changes to script and maven commands so that later when tests are running we get normally generated report?

Yes, after restarting server reports are extractable.

But the other thing, after comparing reports from both server 15.0.0-SNAPSHOT and ./run-server-e2e, server ./run-server-e2e lacks some files and folder, as you can see in screenshot below

(left: ./run-server-e2e, right: 15.0.0-SNAPSHOT)
Screenshot from 2023-04-12 12-20-28

Is this okay? @jabolina

@karesti
Copy link
Collaborator

karesti commented Apr 14, 2023

The feature is ok from the console, but we need a release of Infinispan Dev in 15 for testing

@karesti
Copy link
Collaborator

karesti commented Apr 14, 2023

integration testing needs to be done with a released server

@jabolina
Copy link
Member

The missing files/folders can happen when some of the commands are not available in the system, or, like in this case, if it is unable to copy some of the folders from the server's root. That can happen because of file ownership, for example. +1 for Katia's suggestion of running on a released server.

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need a server release so will be on hold now

@karesti
Copy link
Collaborator

karesti commented May 16, 2023

@dpanshug @andyuk1986 the server Dev01 has been released so we can change the version in main, 14.0 branch will remain with 14.0 server

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 15.0.0.Dev01 server here

@dpanshug dpanshug force-pushed the ISPN-14230-server-report branch 2 times, most recently from 6cfe13d to fe01e35 Compare May 16, 2023 16:25
@dpanshug
Copy link
Collaborator Author

Feature is not working with the released 15.0.0.Dev01 🙄
@jabolina can you confirm if the API is released?

@jabolina
Copy link
Member

I was able to use it on 15.0.0.Dev01 image.

$ docker pull infinispan/server:15.0.0.Dev01
$ docker run -it -p 11222:11222 -e USER="admin" -e PASS="password" infinispan/server:15.0.0.Dev01

On the other terminal:

$ curl --digest -u admin:password -O 'http://127.0.0.1:11222/rest/v2/server/report/f439e0909dbd-59934'

The f439e0909dbd-59934 was the name my server received. The name is printed on the docker output.

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well
the only issue I see is that there is no notification when the download has started.
I click the button and there is some time before the download is happening, so I don't know if it worked or not.
I would add an alert to say the download is happening (green) or that has failed for any reason with the error altert.

@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

unrelated, remove the "over" css from the header

Screenshot 2023-07-04 at 10 16 55

* Table changed to TableComposable
* Labels exported
@karesti karesti merged commit ce8899d into infinispan:main Jul 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants