Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-14835 Use BASIC when url contains user and password #356

Merged
merged 1 commit into from May 16, 2023
Merged

ISPN-14835 Use BASIC when url contains user and password #356

merged 1 commit into from May 16, 2023

Conversation

karesti
Copy link
Collaborator

@karesti karesti commented May 15, 2023 •
edited

@karesti karesti requested a review from andyuk1986 May 15, 2023 12:22
@karesti karesti force-pushed the log-with-basic-automatically branch from ffc410c to 5cd1562 Compare May 15, 2023 12:30
dpanshug
dpanshug reviewed May 16, 2023
View reviewed changes
Copy link
Collaborator

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karesti please recheck the prettier formatting.

dpanshug
dpanshug reviewed May 16, 2023
View reviewed changes
src/app/routes.tsx Outdated Show resolved Hide resolved
@karesti karesti force-pushed the log-with-basic-automatically branch 2 times, most recently from 2b50365 to 5560767 Compare May 16, 2023 13:43
@andyuk1986 andyuk1986 force-pushed the log-with-basic-automatically branch from 8069184 to 13b96d5 Compare May 16, 2023 18:11
@andyuk1986 andyuk1986 force-pushed the log-with-basic-automatically branch from 13b96d5 to ef4f235 Compare May 16, 2023 22:42
andyuk1986
andyuk1986 approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@andyuk1986 andyuk1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, approved. Fixed Unit/Cypress tests.

@andyuk1986 andyuk1986 merged commit 5704a49 into infinispan:main May 16, 2023
1 check passed
@karesti karesti deleted the log-with-basic-automatically branch May 17, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpanshug dpanshug dpanshug left review comments

@andyuk1986 andyuk1986 andyuk1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karesti @andyuk1986 @dpanshug