Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14914 Admin view for cache templates #370

Merged
merged 1 commit into from Jul 4, 2023

Conversation

dpanshug
Copy link
Collaborator

@dpanshug
Copy link
Collaborator Author

To be merged after #368

@andyuk1986
Copy link
Collaborator

andyuk1986 commented Jun 29, 2023

I have rebased, and fixed the test. Looks good to me, the only thing that there in search box I think the text should be changed. Now it says: "Filter by server name" (see screenshot).
Screenshot from 2023-06-29 13-43-04

@dpanshug
Copy link
Collaborator Author

Thanks @andyuk1986, I have fixed that problem.

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some console logs forgotten
other wise

src/app/services/cachesHook.ts Outdated Show resolved Hide resolved
src/app/services/cachesHook.ts Outdated Show resolved Hide resolved
src/app/services/cachesHook.ts Outdated Show resolved Hide resolved
@karesti
Copy link
Collaborator

karesti commented Jul 4, 2023

@dpanshug related failing tests

@karesti karesti merged commit 54ab7f8 into infinispan:main Jul 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants