Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14916 Entries tab #372

Merged
merged 1 commit into from Jul 7, 2023
Merged

Conversation

dpanshug
Copy link
Collaborator

@andyuk1986
Copy link
Collaborator

@dpanshug I have sent a PR to your repo/branch with test fixes.

@dpanshug dpanshug requested a review from karesti June 28, 2023 17:32
@karesti
Copy link
Collaborator

karesti commented Jun 28, 2023

squash the commits and I'll merge plz 🙏🏻

@andyuk1986
Copy link
Collaborator

@karesti done!

Copy link
Collaborator

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several issues

@karesti
Copy link
Collaborator

karesti commented Jul 3, 2023

Screenshot 2023-07-03 at 18 47 48
tooltips are empty

@karesti
Copy link
Collaborator

karesti commented Jul 3, 2023

Screenshot 2023-07-03 at 18 44 00

when there is no entry, the message is not ok

@dpanshug dpanshug force-pushed the ISPN-14916-entries-tab branch 3 times, most recently from 07ce308 to 8f62944 Compare July 3, 2023 17:23
@karesti karesti merged commit 7c92e2f into infinispan:main Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants