ISPN-15198 Cache detail broken for non admin #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
force-pushed
the
fix-main-testing
branch
9 times, most recently
from
db41453
to
d2832cc
Compare
karesti
changed the title
karesti
changed the title
karesti
force-pushed
the
fix-main-testing
branch
5 times, most recently
from
290d19f
to
84e3ef1
Compare
|
related to infinispan/infinispan#11342 |
karesti
force-pushed
the
fix-main-testing
branch
9 times, most recently
from
13e0e16
to
ccfb204
Compare
karesti
force-pushed
the
fix-main-testing
branch
4 times, most recently
from
efcac54
to
221baea
Compare
andyuk1986
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Hi, thanks a lot for your work. I have looked through the test changes - everything looks good, i.e. more structured organization of tests, thanks a lot. I didn't understand the point of the numbers added for test names (I guess it is for correct order of test execution?). Also there was one test failing and there was a typo in npm command in README file. I have fixed it both and added a commit to this PR. If it is ok for you, I will squash commits.
|
yeah, I'm going to pull the commits and squash myself |
karesti
force-pushed
the
fix-main-testing
branch
from
a53f773
to
c95c5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISPN-15198